[
https://issues.apache.org/jira/browse/NUMBERS-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779340#comment-16779340
]
Gilles commented on NUMBERS-74:
-------------------------------
There are formatting nits, trusting from the diff sent on the "notifications@"
ML.
It would be nice to add unit tests.
bq. \[...\] in the end did not take very long at all.
That's the beauty of the KISS principle. :)
> Make "Fraction" a ValJO
> -----------------------
>
> Key: NUMBERS-74
> URL: https://issues.apache.org/jira/browse/NUMBERS-74
> Project: Commons Numbers
> Issue Type: Sub-task
> Components: fraction
> Reporter: Gilles
> Priority: Major
> Labels: API
> Fix For: 1.0
>
>
> [This ML post|https://markmail.org/message/fhrnyg3nfer7y2cy] makes
> suggestions and points to potential issues with that class.
> A.o. things,
> * there seems to be some code overlap between the constructors and the
> {{getReducedFraction}} method (and the latter should probably be private
> anyways),
> * method {{percentageValue}} is not very useful,
> * a lot of constants should be removed,
> * {{serialVersionUID}} should be updated, and moved to the top of the
> declaration list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
