[
https://issues.apache.org/jira/browse/NUMBERS-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780371#comment-16780371
]
Gilles commented on NUMBERS-74:
-------------------------------
bq. formatting nits? Are they posted on the notifications ML?
No.
Indentation is not consistent:
https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java;h=0e3d76f84421a76cccae933d22947952d89c2aca;hb=9a4792cc1cd265d12dde033ac818ef3dea5de816#l649
Tabs were used perhaps?
> Make "Fraction" a ValJO
> -----------------------
>
> Key: NUMBERS-74
> URL: https://issues.apache.org/jira/browse/NUMBERS-74
> Project: Commons Numbers
> Issue Type: Sub-task
> Components: fraction
> Reporter: Gilles
> Priority: Major
> Labels: API
> Fix For: 1.0
>
>
> [This ML post|https://markmail.org/message/fhrnyg3nfer7y2cy] makes
> suggestions and points to potential issues with that class.
> A.o. things,
> * there seems to be some code overlap between the constructors and the
> {{getReducedFraction}} method (and the latter should probably be private
> anyways),
> * method {{percentageValue}} is not very useful,
> * a lot of constants should be removed,
> * {{serialVersionUID}} should be updated, and moved to the top of the
> declaration list.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
