Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-499293189 OK, I've created a [branch](https://github.com/Schamschi/commons-numbers/tree/MigrateToJunit5) too in my fork for the migration to JUnit 5, since I cannot push directly to this branch. I already had some of the test classes fully migrated and committed in my local repository before you created this branch, so there were some merge conflicts when I rebased my local branch onto yours, but I've reviewed them all, and the only conflicting changes made by you I've overwritten were the imports and the parentheses next to the previously parameterized Test annotations for test methods where an exception should be thrown. I'm not sure, but i think that, if the branches are merged via GitHub, GitHub creates an extra merge commit, making the history look ugly, so maybe you'd prefer to pull my branch into your local repository and push it to this branch, provided you agree with my commits. But I've only been here for a short while, so I don't know what the usual modus operandi in situations like this is.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
