Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-500208978 @grimreaper Congratulations! I'll continue with the complex-stream and complex module (working my way up alphabetically from bottom to top, for some reason …). About the fraction module: I see that you have requested that [pull request #36](https://github.com/apache/commons-numbers/pull/36) be delayed until after the migration to JUnit 5. However, I would be in favor of merging the referenced pull request already before the migration (provided it is updated so that it can be merged with master), because this pull request has been slowly decaying into oblivion ever since I submitted it, which was both before we started working on the migration and also before the fraction-dev branch was merged into master. At the time of its submission, the pull request conflicted with the development on fraction-dev because I wasn't aware of the active development on fraction-dev back then, so the pull request was not merged. Now, fraction-dev has been merged into master, but of course, now the pull request conflicts with master, so again, it cannot be merged. So there are two options: I either update the pull request so that it can be merged, or I put it to rest, burying it in the depths of unmerged pull requests and have all the work that went into it go to waste. I'm still undecided on this, but in case I opt for the former, I think it would be much less work to reconstruct the changes that have already been applied to the class `FractionTest` in the migration branch (which I would be willing to do) than to refactor the pull request to not only be compatible with the merge of the fraction-dev branch, but also with the migration to JUnit 5. So I'd suggest that we wait with the fraction module until the pull request is closed, whether it is merged or discarded. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
