Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-499840635 Thanks for letting me know, and it's a good thing you did, because with this force push, you overwrote my migrations of 13 classes from the gamma module, which I had already pushed to the branch. Luckily, I still had them saved in my local repository so I could re-commit them, but the next time you do this, could you please first update your local copy of the branch? Also, when you merged the master branch, you overwrote several changes from the fraction-dev branch when resolving the arisen merge conflicts. Some of these overwrites were beneficial, e.g. converting tabs to spaces or removing redundant whitespace, but some, i.e. those where you refactored the code to use assertThrows, were problematic, because in some cases the merge from the fraction-dev branch to the master branch caused the test methods to invoke different methods/constructors than before, and when you resolved the merge conflicts, you reverted the test methods to invoke the old methods/constructors, which in some cases did not exist anymore, causing the code to be not compilable. I think I have fixed these issues now with my latest commmit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
