Schamschi commented on issue #48: [WIP] perform the actual migration to JUnit 5 URL: https://github.com/apache/commons-numbers/pull/48#issuecomment-502118743 @grimreaper PR [#36](https://github.com/apache/commons-numbers/pull/36) has been merged into master. Since you said it's OK if the pull request is merged, I completely overwrote the previous version of `FractionTest` from this branch with the new version from master when merging master into this branch, and restored the changes that had been made to `FractionTest` in this branch up to that point. From then on, I migrated the file from scratch, meaning I didn't include any of your later changes (this is exactly the scenario I wanted to avoid by agreeing on which pull request should be merged first before any major changes are performed in this branch that would conflict with the other pull request). I also removed the last unused imports, so the branch is now completely independent of JUnit 4. I, on my part, am finished with this branch. Do you intend to work any further on it? If not, what to do next? Write to the dev mailing list? I guess the pom.xml will have to be modified to remove any dependency related to JUnit 4, but I'm not sure how, since I didn't understand all of the changes made to it when adding JUnit 5 as a dependency alongside JUnit 4. In any case, thank you very much for your help.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
