aherbert commented on a change in pull request #56: RNG: 84 - Added members of
the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r305630850
##########
File path:
commons-rng-core/src/test/java/org/apache/commons/rng/core/ProvidersList.java
##########
@@ -94,6 +97,8 @@
add(LIST32, new XoRoShiRo64StarStar(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
add(LIST32, new XoShiRo128Plus(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
add(LIST32, new XoShiRo128StarStar(new int[] {g.nextInt(),
g.nextInt(), g.nextInt()}));
+ add(LIST32, new PcgXshRr32(new long[] {g.nextLong(),
g.nextLong()}));
Review comment:
Can you remove one of the long values passed to the constructor here. It
will test the self seeding path in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
