aherbert commented on a change in pull request #56: RNG: 84 - Added members of 
the PCG suite of generators.
URL: https://github.com/apache/commons-rng/pull/56#discussion_r308007229
 
 

 ##########
 File path: 
commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/ProviderBuilder.java
 ##########
 @@ -220,7 +225,29 @@ public static RestorableUniformRandomProvider 
create(RandomSourceInternal source
         /** Source of randomness is {@link XoShiRo512StarStar}. */
         XO_SHI_RO_512_SS(XoShiRo512StarStar.class,
                          8,
-                         NativeSeedType.LONG_ARRAY);
+                         NativeSeedType.LONG_ARRAY),
+        /** Source of randomness is {@link PcgXshRr32}. */
+        PCG_XSH_RR_32(PcgXshRr32.class,
+                2,
+                NativeSeedType.LONG_ARRAY),
+        /** Source of randomness is {@link PcgXshRs32}. */
+        PCG_XSH_RS_32(PcgXshRs32.class,
+                2,
+                NativeSeedType.LONG_ARRAY),
+        /** Source of randomness is {@link PcgRxsMXs64}. */
+        PCG_RXS_M_XS_64(PcgRxsMXs64.class,
+                2,
+                NativeSeedType.LONG_ARRAY),
+        /** Source of randomness is {@link PcgMcgXshRr32}. */
+        PCG_MCG_XSH_RR_32(PcgMcgXshRr32.class,
+                1,
+                NativeSeedType.LONG),
+        /** Source of randomness is {@link PcgMcgXshRs32}. */
+        PCG_MCG_XSH_RS_32(PcgMcgXshRs32.class,
+                1,
+                NativeSeedType.LONG);
+
 
 Review comment:
   There are some extra blank lines here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to