Claudenw commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-554651103 I think you have it backwards. hash32 is not broken. hash32 -> hash32_x64 to indicate the implementation in the name (deprecate hash32 infavor of the new name). (code can be coalesced around one implementation with hash32() delegating to hash32_x86() calls. hash128 is broken. However there are probably users that can not change from the broken implementation. I think it is the Cassandra project has the same issue and has elected not to change their hash as it breaks all the existing data sets. So hash128 deprecated with a note indicating the error in the code so that users can decide if they need to retain the broken one or not. I will make the changes for Hash32() to call hash30_x86 methods.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
