Claudenw commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-557868665 Nit: I think that in MurmurHash3Test line 740 it should use answers2 not answers: for (int i = 0; i < answers*2*.length; i++) { not for (int i = 0; i < answers.length; i++) { On Thu, Nov 21, 2019 at 4:13 PM Alex Herbert <[email protected]> wrote: > @Claudenw <https://github.com/Claudenw> I have created a separate ticket > for the sign extension bug in hash32 [CODEC-267]. > > I fully documented what the class is currently doing. I rewrote the test > class entirely to ensure that all the documentation for what the various > methods are doing is tested. This tests hashing with random bytes from the > full range of [0-255]. The reference data is from Python mmh3 which is > based on the MurmurHash3 c++ code. > > I created tests to show the sign extension error. > > I then took your fixes for the hash32 bug and hash128 sign extension bug > and implemented them in master. The changes log has been attributed to you. > > Please can you verify that master passes any additional tests you have > written for the PR for the methods with bugs and the new methods, > hopefully, without bugs. > > The new API has a minimal footprint with 4 new methods and a new > IncrementHash32x86 class. I don't think all the other methods are > warranted. See [CODEC-268] for a wish to deprecate most of them. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-codec/pull/27?email_source=notifications&email_token=AASTVHSEMVVSIAB5SCF3XHLQU2XT5A5CNFSM4JIKUON2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2YT6A#issuecomment-557156856>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AASTVHSUYLX5SKT2HLZDKUDQU2XT5ANCNFSM4JIKUONQ> > . > -- I like: Like Like - The likeliest place on the web <http://like-like.xenei.com> LinkedIn: http://www.linkedin.com/in/claudewarren
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
