Claudenw commented on issue #27: Murmur3fix URL: https://github.com/apache/commons-codec/pull/27#issuecomment-554652989 There must be a difference between hash32 and hash32_x86 because when I change hash32() to public static int hash32(final byte[] data, final int offset, final int length, final int seed) { return hash32_x86( data, offset, length, seed ); } The incremental hash test no longer passes. it fails with java.lang.AssertionError: Block size 1 expected:<2094498084> but was:<2002902189> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.apache.commons.codec.digest.MurmurHash3Test.testIncremental(MurmurHash3Test.java:176) . . .
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
