aherbert commented on a change in pull request #56: Added spotbugs check
URL: https://github.com/apache/commons-csv/pull/56#discussion_r376707973
##########
File path: pom.xml
##########
@@ -208,6 +210,14 @@
<suppressionsLocation>${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${spotbugs.plugin.version}</version>
+ <configuration>
+ <excludeFilterFile>${basedir}/sb-excludes.xml</excludeFilterFile>
Review comment:
Can you change this to
`${basedir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml` and move
the exclude file there.
I will separately move checkstyle.xml to the src folder too. No point to
clutter up the root directory with things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
