ameyjadiye commented on a change in pull request #56: Added spotbugs check
URL: https://github.com/apache/commons-csv/pull/56#discussion_r376761541
##########
File path: pom.xml
##########
@@ -208,6 +208,14 @@
<suppressionsLocation>${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${commons.spotbugs.version}</version>
+ <configuration>
+
<excludeFilterFile>${basedir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
Review comment:
Hi, @garydgregory I think src/main/resources is the best place for keeping
these kinds of configs. src/site sounds more like keeping site-related data.
@aherbert, WDYT ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
