garydgregory commented on a change in pull request #56: Added spotbugs check
URL: https://github.com/apache/commons-csv/pull/56#discussion_r376788514
##########
File path: pom.xml
##########
@@ -208,6 +208,14 @@
<suppressionsLocation>${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${commons.spotbugs.version}</version>
+ <configuration>
+
<excludeFilterFile>${basedir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
Review comment:
-1 Sorry @ameyjadiye but `main/resources` is for runtime code, not artifacts
that are solely used to build the web site and perform build-time command line
checks. Some projects store such a file in the root or in `src/site`, the later
is much cleaner than dumping more stuff in the root IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
