GedMarc commented on pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26#issuecomment-623412105
@rmannibucau Nah, it's already in a bank, and two separate clients on a kubernetes cluster with over 150 docker containers. Strongly Disagree, the performance enhancements are enormous, chalk and cheese. To the point where not doing it... looks a bit..,. erg... The numbers are their own proof for a sale. Spring especially is going to struggle moving to modules, i remember working with.. whats his name, eric something or other, on fixing up the classpath scanner for it. Working with EE/CDI is a totally different strategy of development, it breaks language ubiquity, so right there instantly not even a consideration for microservices, DDD, or any future development if you are of the stricter sort, which I am. Yes the SPI rules from JDK 12 and up are very strict, so much so that META-INF/services isn't even scanned anymore, and the declarations and class placements are very strict. You can imagine what that does to all annotation processors and the efforts I went through to get them working again. Each library/module has to be separate, when a module is the only module to reference a single file (like portlet-api) then and only then do I shade it in together. And the kicker - is that every single library has to be named, in order, to build an optimized image. Building the "FAT" jar, zero benefit in a modular AMD world. Mine-as-well stay where you are with class pathing and the old java world. The performance and benefits come from strictly defining each modules path. From what I've gone through, it doesn't sound like you've done this before, sounds all theory and no practice? A lot of things I came across are not documented, yet very very real. Each release of Java since 9 has brought breaking changes in a vast range of libraries. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
