GedMarc commented on pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26#issuecomment-623426267
@rmannibucau nope. Seems you haven't done it before. Sending through a zip for a docker container, is the thing. There are rules around JLink that are very strict in terms of building the JVM. You seem unaware of these. There are also enhancements built in like the JRT filesystem, which you will only get in that world which has its own set of rules to abide by as well. I think you do not understand what the forward movement is. I'm sorry, unfortunately I believe you do not have the experience to actually say items like "Also on the modular point: you are NOT modular when doing a jlink image" The inverse is true - you cannot build a JLink image without it being 100% modular from bottom to top. You are typing out of your *ss and have never built one before. Please attempt to build one with just this library first, then revert your findings. How it matters, and why it is important, is that you will no longer be able to generate the image, the JRE essentially, for JDK 9 and up, which you really should be doing, or what's the point? Your FAT jar provides no benefit. You should stay on 8, and not move up. You will get performance degradation, if you haven't noticed that already. Research AMD architecture, and DDD design (did I double design there?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
