rmannibucau commented on pull request #26: URL: https://github.com/apache/commons-fileupload/pull/26#issuecomment-623432313
@GedMarc this becomes to be pointless so this will be my last answer but you keep saying wrong statements as they are true. As explained you can build jlink images from not jlink friendly jar (just reread the thread if you doubt). Also generating is not important cause you don't gain perf (until you dont compare the same thing as mentionned) nor size in real app (you mentionned hibernate, several commons lib etc - to give you figures I went from 130M to 85M moving to jlink but I lost the ability to cache 120M in a shared docker layer so it was a failure). Also note that the fatjar does not mean java 8 (actually I used it with java 11 and jpms on). JRT wins also disable several features in most libs using the filsystem which means you need to compare what you can compare and tune the standard classpath as you run within jrt FS to be able to conclude anything. Also note there is no possible discussion about if you are modular or not using jlink, it creates an atomic binary (compared to graal which can create a lib) so it is not modular when you use it, it is only modular if you run modules outside an image. Finally in terms of license images are a blocker in several cases so I think you just missed something in your app (like didnt put a custom hibernate scanner for ex and lost a bunch of time there) and thought jlink helped you whereas it didn't as much as your figures show. That said I'm done with this topic in this thread (happy to discuss it elsewhere) cause it is not what it should be about. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
