XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432842061
##########
File path: src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
##########
@@ -144,19 +144,19 @@ public Object get(final String name) {
if (type == Boolean.TYPE) {
return Boolean.FALSE;
} else if (type == Byte.TYPE) {
- return Byte.valueOf((byte) 0);
+ return (byte) 0;
Review comment:
> -1: For a low-level library, I prefer to see boxing and unboxing
explicit so we can best understand where it happens and then consider any
performance issues. For example, in this case `Byte.valueOf((byte) 0)` and
other similar calls in this method should be refactored into constants, which
I've done in git master, so please rebase.
@garydgregory rebase done, and the latest commits fixed PropertyDescriptors
to PropertyDescriptor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
