XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432843902



##########
File path: src/main/java/org/apache/commons/beanutils2/MethodUtils.java
##########
@@ -1150,7 +1150,7 @@ private static float getObjectTransformationCost(Class<?> 
srcClass, final Class<
      *
      * @return true if the assignment is compatible.
      */
-    public static final boolean isAssignmentCompatible(final Class<?> 
parameterType, final Class<?> parameterization) {
+    public static boolean isAssignmentCompatible(final Class<?> parameterType, 
final Class<?> parameterization) {

Review comment:
       @garydgregory 
   this is not needed but `static` functions having `final` is meaningless.
   Or is there any special meaning for this `final` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to