XenoAmess commented on a change in pull request #25:
URL: https://github.com/apache/commons-beanutils/pull/25#discussion_r432844388
##########
File path:
src/main/java/org/apache/commons/beanutils2/locale/converters/StringLocaleConverter.java
##########
@@ -268,7 +268,7 @@ else if (value instanceof Date) { // java.util.Date,
java.sql.Date, java.sql.Tim
*
* @throws ConversionException if conversion cannot be performed
* successfully
- * @throws ParseException if an error occurs parsing a String to a Number
+ * @throws IllegalArgumentException if an error occurs parsing a String to
a Number
Review comment:
@garydgregory
IMO only when `pattern == null` can it be NPE.
but that two functions are in branch `if(pattern != null)`
so I don't think it can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
