[
https://issues.apache.org/jira/browse/MATH-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166763#comment-17166763
]
Gilles Sadowski commented on MATH-1551:
---------------------------------------
There still remain spurious space characters (at some ends of line), and/or
tabs.
Did you run "mvn site"? ["git diff master" will also show them.]
It seems there is some duplicate code between the two {{setData}} methods.
Can't one call the other? I.e.
{code:java}
public void setData(final double[] values, final double[] sampleWeights) {
setData(values, sampleWeights, 0, values.length);
}
{code}
The Javadoc for method {{searchSk}} was duplicated.
Some Javadoc is missing, e.g. at line 373:
{code}
* @throws MathIllegalArgumentException
{code}
This
{code}
* <li>Throws <code>MathIllegalArgumentException</code> if
<code>values</code>
* is null, or <code>start</code> or <code>length</code> is invalid</li>
* </ul>
{code}
should actually be part of the {{@throws}} comment. I think that NPE, not
{{MathIllegalArgumentException}}, is thrown when {{null}} is passed. I know
you copied that from other places, but that class is fairly old and needs many
fixes. :( See a.o. MATH-1169, MATH-1491, MATH-1347.
> Compute Percentile with Weighted Samples
> ----------------------------------------
>
> Key: MATH-1551
> URL: https://issues.apache.org/jira/browse/MATH-1551
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 4.0
> Reporter: institute for information industry
> Priority: Major
> Labels: features, newbie
> Fix For: 4.0
>
> Attachments: Percentile.java
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The class Percentile only support estimation on non-weighted samples.
> I've implement some function to estimate percentiles of weighted samples.
> here is the reference:
> [https://stats.stackexchange.com/questions/13169/defining-quantiles-over-a-weighted-sample]!https://mail.google.com/mail/u/0?ui=2&ik=6059a2f2a6&attid=0.1&permmsgid=msg-a:r-8896240918589631988&th=1737bdaafc3e228f&view=fimg&sz=s0-l75-ft&attbid=ANGjdJ_GwCQ-hqi0o7ZJTEqcl6JLYbFiR2Y1sqxPL8jDNzheraAkX0beEUtAM4BYI2v_5XGvzCPj2gTBQutHT9bF8hYh7MgdiGYZhn0HtDuVswuCSuwy8aJVsvy3EqI&disp=emb&realattid=ii_kcyrjgea0!
>
> When all weights are equal to each other, it works like estimation on
> non-weighted samples under R-7.
> I can't find formulas for other rules but at least, now it can evaluate
> percentile for weighted samples.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
