[ 
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183907#comment-17183907
 ] 

Gilles Sadowski commented on LANG-1601:
---------------------------------------

{quote}I checked commons-number's class Fraction's function pow. It looks good, 
and seems can be ported to commons-lang after several changes. [...] really far 
faster now.
{quote}
Isn't this class the typical example of why code duplication is to be avoided?

My remark aimed at deprecating/removing the code in [Lang] after ensuring that 
the functionality is correctly implemented in [Numbers].

The differences which you note are implementation details: They don't pertain 
to the concept of fraction; so a user of [Lang]'s implementation should be able 
to switch to [Numbers]'s implementation without loosing any important 
functionality.

> refine performance of Fraction.pow
> ----------------------------------
>
>                 Key: LANG-1601
>                 URL: https://issues.apache.org/jira/browse/LANG-1601
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.math.*
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to