[
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183939#comment-17183939
]
Jin Xu commented on LANG-1601:
------------------------------
[~erans]
Hi.
After a deeper look at the two sources, I noticed two things.
1. there be some designing differences between the two versions.
In commons-lang's version of Fraction, a Fraction is allowed to be created as
6/10, and only when people invoke reduce() will it returns a 3/5.
But in commons-numbers's version of Fraction, we make sure the Fraction MUST be
redueced when build, i.e. we get Fraction(6,10) , the result we get is actually
3/5, not 6/10.
If we want to merge these two Classes, we must write some additional documents
for this.
2. in commons-lang's version of Fraction.pow, they have a special treatement to
make sure Integer.MIN_VALUE can be used as exponent.
Is this valuable?
Should I port this feature to the version in commons-numbers?
> refine performance of Fraction.pow
> ----------------------------------
>
> Key: LANG-1601
> URL: https://issues.apache.org/jira/browse/LANG-1601
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
