[ 
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184113#comment-17184113
 ] 

Alex Herbert commented on LANG-1601:
------------------------------------

What do you think should be ported? A quick scan over the Fraction class in 
lang finds bugs that have been resolved in numbers.

The additional methods I can see are:
{code:java}
public int getProperNumerator()
public int getProperWhole()
public String toProperString()
{code}
These deal with representing the fraction {{A/B}} as {{X Y/Z}} with {{X}} a 
whole integer. This seems to be unworthy of porting. It could be put into a 
FractionFormatter class.

The other methods just have name changes:
{noformat}
invert == reciprocal
divideBy == divide
multiplyBy == multiply
{noformat}
The {{reduce()}} method is not required as numbers always reduces the Fraction.

> refine performance of Fraction.pow
> ----------------------------------
>
>                 Key: LANG-1601
>                 URL: https://issues.apache.org/jira/browse/LANG-1601
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.math.*
>            Reporter: Jin Xu
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to