[
https://issues.apache.org/jira/browse/LANG-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184171#comment-17184171
]
Gilles Sadowski commented on LANG-1601:
---------------------------------------
{quote}These deal with representing the fraction A/B as X Y/Z with X a whole
integer. This seems to be unworthy of porting. It could be put into a
FractionFormatter class.
{quote}
+1 (as per my comments in NUMBERS-149).
{quote}2. cached toString and hashCode property, to avoid calculate twice.
{quote}
Implementation detail (not worth supporting IMO but should be examined with a
view towards the other "number" classes).
{quote}3. some changes in function pow (which I think good).
{quote}
Specific code improvements must be committed separately.
{quote}I found a new usage to give it. You can see more details in that pr.
{quote}
I don't see any details in the PR's commit messages or description. The
NUMBERS-149 JIRA page is the place to argue about what should be ported or not.
{quote}I just, tried to make users feel as less un-familiar as I can, when they
try to turn from lang's Fraction to numbers' Fraction.
{quote}
Not a design goal. ;)
Developers willing to do the switch should make the effort to adapt to a
different design in exchange for the benefits (like bug fixes). If they don't
want to touch their code, they can keep on using the [Lang3] for {{Fraction}}
even if they upgrade for the rest.
> refine performance of Fraction.pow
> ----------------------------------
>
> Key: LANG-1601
> URL: https://issues.apache.org/jira/browse/LANG-1601
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.math.*
> Reporter: Jin Xu
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://github.com/apache/commons-lang/pull/611
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
