garydgregory commented on a change in pull request #68:
URL: https://github.com/apache/commons-dbcp/pull/68#discussion_r498292377
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##########
@@ -94,6 +100,8 @@
private Integer defaultQueryTimeoutSeconds;
+ private final ExecutorService executor = Executors.newFixedThreadPool(3,
new AbortThreadFactory());
Review comment:
> If it needs to be configured why a system property rather than a
property of the factory?
Sure, I just wanted to avoid not having an override. I meant the sys prop to
be a placeholder hack as an example impl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
