psteitz commented on a change in pull request #68:
URL: https://github.com/apache/commons-dbcp/pull/68#discussion_r498321138
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##########
@@ -94,6 +100,8 @@
private Integer defaultQueryTimeoutSeconds;
+ private final ExecutorService executor = Executors.newFixedThreadPool(3,
new AbortThreadFactory());
Review comment:
I was also worried about the issues @rmannibucau mentions, but did not
think of the option he recommends. Unless I am missing something, I think it
should work and would be +1 to that change. Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
