garydgregory commented on a change in pull request #68:
URL: https://github.com/apache/commons-dbcp/pull/68#discussion_r498323112
##########
File path: src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java
##########
@@ -668,4 +685,27 @@ public boolean validateObject(final
PooledObject<PoolableConnection> p) {
return false;
}
}
+
+ @Override
+ public void close() {
+ executor.shutdown();
+ }
+
+ /**
+ * Thread factory that creates daemon threads, with the context class
loader from this class.
+ */
+ private static class AbortThreadFactory implements ThreadFactory {
Review comment:
Since this is a stateless class, we could create a singleton instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
