kinow commented on a change in pull request #98:
URL: https://github.com/apache/commons-imaging/pull/98#discussion_r500125515
##########
File path:
src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
##########
@@ -53,14 +53,17 @@ public boolean stripsNotTiles() {
@Override
public ImageDataReader getDataReader(final TiffDirectory directory,
- final PhotometricInterpreter photometricInterpreter,
- final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
- final int samplesPerPixel, final int width, final int height,
final int compression,
- final ByteOrder byteOrder) throws IOException, ImageReadException {
+ final PhotometricInterpreter photometricInterpreter,
+ final int bitsPerPixel, final int[] bitsPerSample, final int
predictor,
+ final int samplesPerPixel, final int width, final int height,
+ final int compression,
+ final int planarConfiguration,
Review comment:
@gwlucastrig last change before merging this PR. We have some enum's
like `DisposalMethod`, `IptcTypes`, png `FilterType`, `TiffDirectoryType`…
I think we should create some enum like `TiffPlanarConfiguration` for this
setting. Do you think that would i) make sense and ii) work?
Nothing to add besides that, we have tests, code is in order, bug appears to
be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
