gwlucastrig commented on pull request #98: URL: https://github.com/apache/commons-imaging/pull/98#issuecomment-704201263
Okay. I will update the pull request to use the TiffPlanarConfiguration enumerated type. On Tue, Oct 6, 2020, 6:50 AM Bruno P. Kinoshita <[email protected]> wrote: > *@kinow* commented on this pull request. > ------------------------------ > > In > src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java > <https://github.com/apache/commons-imaging/pull/98#discussion_r500180247>: > > > @@ -53,14 +53,17 @@ public boolean stripsNotTiles() { > > @Override > public ImageDataReader getDataReader(final TiffDirectory directory, > - final PhotometricInterpreter photometricInterpreter, > - final int bitsPerPixel, final int[] bitsPerSample, final int predictor, > - final int samplesPerPixel, final int width, final int height, final int compression, > - final ByteOrder byteOrder) throws IOException, ImageReadException { > + final PhotometricInterpreter photometricInterpreter, > + final int bitsPerPixel, final int[] bitsPerSample, final int predictor, > + final int samplesPerPixel, final int width, final int height, > + final int compression, > + final int planarConfiguration, > > Making planar configuration an enum would be a good idea. I see that you > self-assigned this. Does that mean you'll be making the change? > > No, sorry it's just an old habit. I believe I cannot assign the issue to > you as you are an external contributor. I normally assign issues & PR's to > myself so other common developers are aware I'm interested in > working/finishing work on some issue. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-imaging/pull/98#discussion_r500180247>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEWJDYNAE7UN6M2CJ2M7WQTSJLY57ANCNFSM4RSXZ7OQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
