boris-petrov commented on a change in pull request #151:
URL: https://github.com/apache/commons-vfs/pull/151#discussion_r545142946
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
##########
@@ -1232,6 +1233,7 @@ public FileName getName() {
return fileName;
}
+ // TODO: remove this method for the next major version as it is unused
Review comment:
It's a public method, right. Note, however, that users of VFS always use
`FileObject` which is an interface and it doesn't have this method. It's only
available if one casts explicitly to `AbstractFileObject` (which no one should
do) and to sub-classes (which should not call it at all). The only place this
will be called is in `DefaultFileContent` (actually not this but the other
overload). That's why I've written that this can be removed - so that in the
future a conversation like this is not done. :smiley:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
