garydgregory commented on a change in pull request #151:
URL: https://github.com/apache/commons-vfs/pull/151#discussion_r549897109
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
##########
@@ -1232,6 +1233,7 @@ public FileName getName() {
return fileName;
}
+ // TODO: remove this method for the next major version as it is unused
Review comment:
Hi @boris-petrov
It does not matter as `AbstractFileObject` is a public method.
>if one casts explicitly to AbstractFileObject (which no one should do)
Again, i does not matter as the class is available for 3rd party providers
to subclass. Remember that anyone can plugin their own provider(s) in the
framework, it's designed to be extensible. There are two kinds of clients of
the API: (1) Traditional consumers of the API, and (2) File System providers,
like VFS itself.
For 3.0 we can consider breaking the APIs but we are not there yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
