boris-petrov commented on a change in pull request #151:
URL: https://github.com/apache/commons-vfs/pull/151#discussion_r550232938
##########
File path:
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileObject.java
##########
@@ -1232,6 +1233,7 @@ public FileName getName() {
return fileName;
}
+ // TODO: remove this method for the next major version as it is unused
Review comment:
You are correct for the two usages. My point is that *neither* customers
of the API, *nor* FS providers should be calling these methods. Hence they
could be made `final` and package-private. But not before 3.0 as you said. And
because we're not there, I've added the TODOs so this is not forgotten.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
