timbru31 commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439287998
##########
File path: bin/templates/platform_www/cdv-electron-main.js
##########
@@ -18,10 +18,37 @@
*/
const fs = require('fs');
+const path = require('path');
// Module to control application life, browser window and tray.
-const { app, BrowserWindow } = require('electron');
+const {
+ app,
+ BrowserWindow,
+ protocol
+} = require('electron');
// Electron settings from .json file.
const cdvElectronSettings = require('./cdv-electron-settings.json');
+const reservedScheme = require('./cdv-reserved-scheme.json');
+
+const scheme = cdvElectronSettings.scheme;
+const hostname = cdvElectronSettings.hostname;
+const isFileProtocol = scheme === 'file';
+
+/**
+ * The base url path.
+ * E.g:
+ * When scheme is defined as "file" the base path is
"file://path-to-the-app-root-directory"
+ * When scheme is anything except "file", for example app, the base path will
be "app://localhost"
Review comment:
```suggestion
* When scheme is anything except "file", for example "app", the base path
will be "app://localhost"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
