erisu commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439299290
##########
File path: bin/templates/platform_www/cdv-electron-main.js
##########
@@ -62,10 +89,27 @@ function createWindow () {
});
}
+function configureProtocol () {
+ protocol.registerFileProtocol(scheme, (request, _cb) => {
Review comment:
I prefix it to avoid the lint error
> error Unexpected literal in error position of callback
`standard/no-callback-literal`
I could maybe disabled `standard/no-callback-literal ` with
```
// eslint-disable-line standard/no-callback-literal
```
But then that means eslint rules are in production code when they might not
use eslint...
Maybe instead I can disable `standard/no-callback-literal` for that entire
file by adding the rule to `.eslintrc`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
