timbru31 commented on a change in pull request #154:
URL: https://github.com/apache/cordova-electron/pull/154#discussion_r439289294
##########
File path: bin/templates/platform_www/cdv-electron-main.js
##########
@@ -62,10 +89,27 @@ function createWindow () {
});
}
+function configureProtocol () {
+ protocol.registerFileProtocol(scheme, (request, _cb) => {
Review comment:
Any reason for prefixing `cb`? Normally, I'll do this only if it's
unused, but it's called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
