raphinesse edited a comment on pull request #1130: URL: https://github.com/apache/cordova-android/pull/1130#issuecomment-731737744
> Do we really want the name of the file as `Java.js` and not `java.js`? I believe in almost every repo our filenames are lowercased. We actually have quite a few modules with non-lowercase filenames in this repo that exactly match the exported class' name: `AndroidManifest.js`, `AndroidProject.js`, ... That being said, if we change this module from a class to a plain object, `java.js` would be fine with me as well. In fact, maybe the name could be more descriptive yet. Something like `env/java.js`, for example... :man_shrugging: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
