breautek commented on pull request #1130: URL: https://github.com/apache/cordova-android/pull/1130#issuecomment-732209907
> That being said, if we change this module from a class to a plain object, `java.js` would be fine with me as well. In fact, maybe the name could be more descriptive yet. Something like `env/java.js`, for example... Coding habits from my own projects. I can convert this into a simple JS object and move the file to an `env/` folder. We could follow a similar pattern going forward with android studio, adb, bundle tools, etc... I would want to keep the module exporting an object containing methods though as this makes it easy to unit test/spy functions without the use of rewire, and I personally want to try to limit the use of rewire as much as possible since it's not a package that is actually maintained. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
