[ 
https://issues.apache.org/jira/browse/CB-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753973#comment-13753973
 ] 

Braden Shepherdson commented on CB-4609:
----------------------------------------

... why are you moving cordova.js? That's not supported, as you've discovered. 
I'd like to see a compelling reason for the extra complication before pulling 
in those PRs.

Also it looks like the changes to Plugman are relying on the CLI folder 
structure, which isn't allowed. We want Plugman to remain a standalone tool.

The Windows path thing is a bug, though - adding from a path and then deleting 
by ID should work.
                
> relative path to cordova.js & windows path
> ------------------------------------------
>
>                 Key: CB-4609
>                 URL: https://issues.apache.org/jira/browse/CB-4609
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Plugman
>    Affects Versions: 3.0.0
>         Environment: Window 8, node v0.10.16
>            Reporter: Jonathan Bond-Caron
>            Assignee: Filip Maj
>         Attachments: Result of 'plugin add'.jpg
>
>
> I'm experimenting with a new plugin:
> https://github.com/jbondc/cordova-plugin-gesture
> To reproduce:
> - Download https://github.com/jbondc/mtlhack-PhoneGap-gesture
> 1) Issue #1
> {code}
> cd cordova
> plugin add https://github.com/jbondc/cordova-plugin-gesture
> {code}
> Since cordova.js isn't in the default path (www/resources/cordova.js), the 
> plugins gets copied to (www/plugins/) instead of (www/resources/js/plugins).
> The same for 'cordova_plugins.js' (see attached screenshot)
> Fix is likely in the cli/plugman to set find the appropriate root/base path 
> to cordova.js
> 2) Issue #2
> Adding a plugin from a Windows path
> {code}
> cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
> {code}
> In cordova_plugins.js, I see:
> {code}
> cordova.define('cordova/plugin_list', function(require, exports, module) {
> module.exports = [
>     {
>         "file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
>         "id": "org.apache.cordova.core.Gesture.Gesture",
>         "clobbers": [
>             "cordova.gesture"
>         ]
>     }
> ]
> });
> {code}
> That path should be normalized to: 
> "plugins/org.apache.cordova.core.Gesture/www/gesture.js"
> Fix is likely in cli/plugman:
> {code}path.replace("\\", "/"){code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to