[
https://issues.apache.org/jira/browse/CB-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755537#comment-13755537
]
Jonathan Bond-Caron commented on CB-4609:
-----------------------------------------
Are the hooks only for 'cordova-cli'? If you think it's more maintainable that
way, I'm fine with it.
Plugman on its own still expects a certain 'app layout' (where does it put
JavaScript plugins/)
I updated app.js so it caches glob() and is a little safer.
https://github.com/jbondc/cordova-plugman/commit/b40d0797c590eaf9114709bd3072f73521f0e597
What's the concern with this approach?
> relative path to cordova.js & windows path
> ------------------------------------------
>
> Key: CB-4609
> URL: https://issues.apache.org/jira/browse/CB-4609
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Plugman
> Affects Versions: 3.0.0
> Environment: Window 8, node v0.10.16
> Reporter: Jonathan Bond-Caron
> Assignee: Filip Maj
> Attachments: Result of 'plugin add'.jpg
>
>
> I'm experimenting with a new plugin:
> https://github.com/jbondc/cordova-plugin-gesture
> To reproduce:
> - Download https://github.com/jbondc/mtlhack-PhoneGap-gesture
> 1) Issue #1
> {code}
> cd cordova
> plugin add https://github.com/jbondc/cordova-plugin-gesture
> {code}
> Since cordova.js isn't in the default path (www/resources/cordova.js), the
> plugins gets copied to (www/plugins/) instead of (www/resources/js/plugins).
> The same for 'cordova_plugins.js' (see attached screenshot)
> Fix is likely in the cli/plugman to set find the appropriate root/base path
> to cordova.js
> 2) Issue #2
> Adding a plugin from a Windows path
> {code}
> cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
> {code}
> In cordova_plugins.js, I see:
> {code}
> cordova.define('cordova/plugin_list', function(require, exports, module) {
> module.exports = [
> {
> "file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
> "id": "org.apache.cordova.core.Gesture.Gesture",
> "clobbers": [
> "cordova.gesture"
> ]
> }
> ]
> });
> {code}
> That path should be normalized to:
> "plugins/org.apache.cordova.core.Gesture/www/gesture.js"
> Fix is likely in cli/plugman:
> {code}path.replace("\\", "/"){code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
