breautek commented on PR #1550: URL: https://github.com/apache/cordova-android/pull/1550#issuecomment-1401985765
Looks like a great start. I wonder if we can update the [updateIcons](https://github.com/apache/cordova-android/blob/3340e98519716f1b1bb55c7b019b145fbe13b26b/lib/prepare.js#L648) function so that we can optionally specify a monochrome icon via the `<icon>` directives. A full example may look like: ```xml <icon density="xxxhdpi" background="adaptive_bg.png" foreground="adaptive_fg.png" monochrome="monochrome.png" src="xxxhdpi.png" /> ``` Traditionally we always supported both rasterized images as well as vectors, but if monochrome doesn't support a rasterized image then we will just need to make sure we note that when we document the feature. The android docs does mention that adaptive icons are required to be declared if using the monochrome, so if the `monochrome` attribute is present, then we can forcefully require the `background` and `foreground` attributes on our `icon` directive. > To support this feature, your app must provide both an [adaptive icon](https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive) and a monochromatic app icon Hopefully the existing code is readable enough that the pattern can be followed, e.g. copying the icon resource to the appropriate drawable folder by density, then writing the changes into the adaptive icon xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
