liyamahendra commented on PR #1550: URL: https://github.com/apache/cordova-android/pull/1550#issuecomment-1402077689
Thank you for the feedback @breautek ! > I wonder if we can update the updateIcons function I was aiming to solve the first use case as documented in the description of the PR. In this scenario, `updateIcons` returns because `icons.length` is Zero. I assume we need to provide some default assets, is that correct? Is providing a default monochrome icon done correctly? I did read through `prepare.js` where we define a `icLauncherTemplate` with content of `adaptive-icon`. I'll add the monochrome statement to the template. I'll add a note to my TODO to make sure we update the docs as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
