liyamahendra commented on PR #1550: URL: https://github.com/apache/cordova-android/pull/1550#issuecomment-1403557509
@breautek I think I've finished the implementation for support for monochrome icons. Kindly review the code. Apart from changes in this project, I had to do a small change in `cordova-common`, the details of which can be seen [here](https://github.com/liyamahendra/cordova-common/blob/8f415cfa2e304692f3d4c783e8fa916b65d072b7/src/ConfigParser/ConfigParser.js#L570). So far, I've covered two use cases - (i) Cordova Starter project created with `cordova create <ProjectName>` and (ii) An existing project where the `config.xml` file has icons defined. A sample Cordova project was created to test use case 2, which can be found [here](https://github.com/liyamahendra/HelloCordova). If everything looks good, we'll have to update the docs. Please let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
