breautek commented on code in PR #277:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/277#discussion_r1287050162
##########
src/android/Capture.java:
##########
@@ -377,20 +381,54 @@ else if (resultCode == Activity.RESULT_CANCELED) {
}
}
-
public void onAudioActivityResult(Request req, Intent intent) {
- // Get the uri of the audio clip
- Uri data = intent.getData();
- if (data == null) {
- pendingRequests.resolveWithFailure(req,
createErrorObject(CAPTURE_NO_MEDIA_FILES, "Error: data is null"));
- return;
+ Uri srcContentUri = intent.getData();
Review Comment:
I agree with the variable name `srcContentUri` here as a way to
self-document what the data is, or at least what was the expectation at the
time of writing the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
