ath0mas commented on code in PR #277:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/277#discussion_r1304948429
##########
src/android/Capture.java:
##########
@@ -377,19 +381,60 @@ else if (resultCode == Activity.RESULT_CANCELED) {
}
}
-
public void onAudioActivityResult(Request req, Intent intent) {
- // Get the uri of the audio clip
- Uri data = intent.getData();
- if (data == null) {
+ Uri srcContentUri = intent.getData();
+
+ if (srcContentUri == null) {
pendingRequests.resolveWithFailure(req,
createErrorObject(CAPTURE_NO_MEDIA_FILES, "Error: data is null"));
return;
}
- // Create a file object from the uri
- JSONObject mediaFile = createMediaFile(data);
- if (mediaFile == null) {
- pendingRequests.resolveWithFailure(req,
createErrorObject(CAPTURE_INTERNAL_ERR, "Error: no mediaFile created from " +
data));
+ // Get file name
Review Comment:
What about not replacing but adding this new code inside the `if (mediaFile
== null) {` as a "fallback"?
To not copy to and use the cacheDir if the captured audio file is already
"correct".
(see my branch
[capture-audio-fallback-cachedir](https://github.com/ath0mas/cordova-plugin-media-capture/commits/capture-audio-fallback-cachedir))
My first tests with your POC went really well 👍!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
