ath0mas commented on code in PR #277:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/277#discussion_r1287396300
##########
src/android/Capture.java:
##########
@@ -377,20 +381,54 @@ else if (resultCode == Activity.RESULT_CANCELED) {
}
}
-
public void onAudioActivityResult(Request req, Intent intent) {
- // Get the uri of the audio clip
- Uri data = intent.getData();
- if (data == null) {
- pendingRequests.resolveWithFailure(req,
createErrorObject(CAPTURE_NO_MEDIA_FILES, "Error: data is null"));
- return;
+ Uri srcContentUri = intent.getData();
+
+ // Get file name
+ String srcContentUriString = srcContentUri.toString();
+ String fileName =
srcContentUriString.substring(srcContentUriString.lastIndexOf('/') + 1);
+
+ // Create dest file path
+ String tempRoot =
cordova.getActivity().getCacheDir().getAbsolutePath();
+ String destFile = tempRoot + "/" + fileName;
+
+ // Create dest file
+ File tmpRootFile = new File(destFile);
+
+ try {
+ // If file exists
Review Comment:
Why not splitting but balanced, as I see other capture types have runtime
exception throwing in some cases, checks on null after it, or so. Again maybe
keep some sort of common pattern and not go for a new structure only for Audio?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
