erisu commented on code in PR #1872: URL: https://github.com/apache/cordova-android/pull/1872#discussion_r2562436193
########## README.md: ########## @@ -19,9 +19,7 @@ # --> -# Cordova Android - -[](https://nodei.co/npm/cordova-android/) +# Cordova Android  Review Comment: This is the new badge we’ve been applying to some repos. I’d like to avoid having too many different badge designs and layouts, but there would still be some degree of confusion. I also don't think we should be showing the "GitHub package.json version." If we do show it, it should at least be placed some where else, not next to the title.Maybe at the bottom of the README, or below the exisiting badge but in a table format and declaring it as an active development version. Including it might reduce confusion for people reading the README in the repo, but it would still cause confusion for people viewing the package on the npm registry. For example, if the repo is tagged as `16.0.0-dev`, and that badge appeared in the `14.0.1` release, anyone reading the `14.0.1` page on npm might wonder why it shows `16.0.0-dev` at the top. However, both the current badge and my suggested badge only report the latest official release. Even the current badge wouldnt accurately show the version that a user is installing. Maybe the current badge I suggested should also include the label of "Latest Release" so its clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
