GitToTheHub commented on code in PR #1872: URL: https://github.com/apache/cordova-android/pull/1872#discussion_r2564609514
########## README.md: ########## @@ -19,9 +19,7 @@ # --> -# Cordova Android - -[](https://nodei.co/npm/cordova-android/) +# Cordova Android  Review Comment: You are right, the users on NPM would also see the development version in the title and would get confused. I started in my repos to manually add the current package version in the title like in https://github.com/katzer/cordova-plugin-local-notifications. But thought, maybe it could be made automatic, so you don't have to update it manually. This was my first try here to made it automatic and now see which disadvantage it have. I like your gist approach, but see you are using there also `shields.io`. I didn't see on `nodei.co` that it supports a label option. How would do you find it, to place manually the package version in the title? If the package gets published to npm the version would be correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
