erisu commented on code in PR #1872: URL: https://github.com/apache/cordova-android/pull/1872#discussion_r2564773932
########## README.md: ########## @@ -19,9 +19,7 @@ # --> -# Cordova Android - -[](https://nodei.co/npm/cordova-android/) +# Cordova Android  Review Comment: > How would do you find it, to place manually the package version in the title? I would personally prefer to avoid adding more places where version numbers need to be maintained within the repo. We already have the version in `package.json`, `package-lock.json`, `RELEASENOTES.md` (updated during release), and other files depending on the package. The more places we have to update, the higher the risk of forgetting one. I've had cases before—outside of Cordova—where I released a package and forgot to update a version in a file, simply because I didn't remember it existed. I ended up having to publish a patch just to fix that oversight. If the badges are going to cause confusion, then I would rather remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
