GitToTheHub commented on PR #573: URL: https://github.com/apache/cordova/pull/573#issuecomment-3683054431
@raphinesse I mean, what @erisu was writing: > I think what Tim is trying to say is that the current diagram is saved and served from your gist URL, and we don’t have permission to edit it. We cannot edit your gist, but copy it and change the url in the readme. I would be for leaving the diagram code in the readme, so it's on one place and everyone who have access to this repo can edit it. Another advantage is, that it applies to dark mode: <img width="1042" height="527" alt="image" src="https://github.com/user-attachments/assets/a5f0dfe6-a2c1-4dee-9d1d-2eec21d6e34d"; /> @erisu > I even created my own Sketchviz of this awhile back to test something. It could even be used if preferred. My graph had removed some things that I found less important in the usual Cordova workflow but could be re-added. I would leave the diagram like it is. But you could make a PR after that PR and change it if you want. If everything is ok now, I would merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
